community[patch]: change default Neo4j username/password #25226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
community
ccurme
approved these changes
Aug 9, 2024
dosubot
bot
added
the
lgtm
|
Hmm when auth is disabled, wouldn't it rather leave off the auth parameter in the driver? Missing credentials is actually more helpful than "wrong credentials" here ... I can imagine searching for the bug e.g. a wrong path or a misspelled env variable for ages when it says wrong credentials instead of missing. |
eyurtsev
previously requested changes
Aug 9, 2024
dosubot
bot
removed
the
lgtm
dosubot
bot
added
size:S
|
cc @tomasonjo |
|
LGTM
V čet., 29. avg. 2024, 11:27 je oseba Bagatur ***@***.***>
napisala:
… cc @tomasonjo <https://github.com/tomasonjo>
—
Reply to this email directly, view it on GitHub
<#25226 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYGGTMUEQRW7WQG4EYEOY3ZT2BJ7AVCNFSM6AAAAABMIHDA36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWGU4TGNBTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
needs to be formatted, otherwise lgtm |
Thanks @hwchase17 -- sorry to have missed the linting issue, it should be green-lit now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change the default Neo4j username/password (when not supplied as environment variable or in code) from
Noneto"".Neo4j has an option to disable auth which is helpful when developing. When auth is disabled, the username / password through the
neo4jmodule should be""(ie an empty string).Empty strings get marked as false in
langchain_core.utils.env.get_from_dict_or_env-- changing this code / behaviour would have a wide impact and is undesirable.In order to both allow access to Neo4j with auth disabled and not impact
langchain_corethis patch is presented. The downside would be that if a user forgets to set NEO4J_USERNAME or NEO4J_PASSWORD they would see an invalid credentials error rather than missing credentials error. This could be mitigated but would result in a less elegant patch!Issue:
Fix issue where langchain cannot communicate with Neo4j if Neo4j auth is disabled.
Twitter handle: @danodonovan